Skip to content

feat: add filtered subquery update test #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
henadzit merged 1 commit into from
Jan 4, 2025
Merged

feat: add filtered subquery update test #1838

henadzit merged 1 commit into from
Jan 4, 2025

Conversation

@Invisi
Copy link
Contributor

@Invisi Invisi commented Jan 4, 2025 •
edited by henadzit
Loading

Description

Adds a missing test for updates on filtered queries with subqueries.

Motivation and Context

Should close #1802

How Has This Been Tested?

make test

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 4, 2025

CodSpeed Performance Report

Merging #1838 will not alter performance

Comparing Invisi:develop (e7a4e08) with develop (7afc90e)

Summary

✅ 8 untouched benchmarks

@coveralls
Copy link

coveralls commented Jan 4, 2025

Pull Request Test Coverage Report for Build 12605666796

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.145%
Totals Coverage Status
Change from base Build 12596506172: 0.0%
Covered Lines: 6460
Relevant Lines: 7048
💛 - Coveralls

@henadzit
Copy link
Contributor

henadzit commented Jan 4, 2025

Thanks for working on this!

@henadzit henadzit merged commit 0aee52d into tortoise:develop Jan 4, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henadzit henadzit henadzit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add tests: update on filtered query fails when using subquery

3 participants

@Invisi @coveralls @henadzit